Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade protomaps leaflet and remove mvt imagery provider #7144

Merged
merged 21 commits into from
Feb 4, 2025

Conversation

@nf-s nf-s changed the base branch from upgrade-protomaps to main May 7, 2024 07:22
@nf-s nf-s changed the base branch from main to upgrade-protomaps May 7, 2024 07:22
buildprocess/configureWebpack.js Outdated Show resolved Hide resolved
@nf-s nf-s marked this pull request as draft May 7, 2024 07:23
@nf-s nf-s changed the base branch from upgrade-protomaps to main December 10, 2024 06:30
@nf-s nf-s changed the title Upgrade protomaps leaflet Upgrade protomaps leaflet and remove mvt imagery provider Dec 10, 2024
@TerriaJS TerriaJS deleted a comment from CLAassistant Dec 10, 2024
@CLAassistant
Copy link

CLAassistant commented Dec 11, 2024

CLA assistant check
All committers have signed the CLA.

@nf-s nf-s marked this pull request as ready for review December 12, 2024 05:42
package.json Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@nf-s nf-s mentioned this pull request Dec 13, 2024
24 tasks
package.json Show resolved Hide resolved
Copy link
Collaborator

@na9da na9da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nf-s Looks great, I have made a few minor comments.

@nf-s
Copy link
Contributor Author

nf-s commented Jan 30, 2025

Thanks for the suggestions, I have applied requested changes. This is ready for another review, thanks!

@nf-s nf-s requested a review from na9da January 30, 2025 04:36
Copy link
Collaborator

@na9da na9da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @nf-s. I leave it to you to merge.

@nf-s nf-s merged commit 6033137 into main Feb 4, 2025
9 checks passed
@nf-s nf-s deleted the upgrade-protomaps-leaflet branch February 4, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants