-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade protomaps leaflet and remove mvt imagery provider #7144
Conversation
…eatures + move GeojsonSource to separate file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nf-s Looks great, I have made a few minor comments.
Thanks for the suggestions, I have applied requested changes. This is ready for another review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @nf-s. I leave it to you to merge.
Upgrade protomaps leaflet
Fixes
protomaps.js
- now calledprotomaps-leaflet
#6858To be merged into #6725Todo
lib/Map/Vector/MapboxJsonStyleToProtomaps.ts
To test
This PR shouldn't impact usage of region mapping or MapboxVectorTileCatalogItem - so here are some examples to compare
MVT with simple Mapbox style spec
Region mapping (with picked feature)