Tile ArcGis FeatureServer requests

CHANGES.md

@@ -2,12 +2,29 @@
 
 #### next release (8.7.12)
 
+**Breaking changes**
+
+- Add tiling support to `ArcGisFeatureServerCatalogItem` - this will be enabled by default if the server supports tiling and unsupported marker/point styles aren't used. See `ArcGisFeatureServerCatalogTraits` `tileRequests`. When enabled, `pbf` tiles will be fetched and drawn using `ProtomapsImageryProvider`
+
+  - This can be disabled by setting `tileRequests` to `false`
+  - For point features, only the following `PointSymbolTraits` are available - fill, stroke, radius (which uses height). Custom markers (markers other than `point` or `circle`) are not supported.
+
 - Remove `MapboxImageryProvider`, `createRegionMappedImageryProvider` now uses `ProtomapsImageryProvider`.
 - Update `protomaps` to `protomaps-leaflet`. This fixes the 5400 vertex limit in a single tile.
   - The very basic support of mvt style spec is now handled by Terria in [`lib/Map/Vector/mapboxStyleJsonToProtomaps.ts`](lib/Map/Vector/mapboxStyleJsonToProtomaps.ts)
 - Move `GeojsonSource` to new file `lib/Map/Vector/ProtomapsGeojsonSource.ts`.
 - support URL parameters in a GetLegendGraphic request for a layer without a style configured
 - Enhanced error processing for obtaining user location
+- Add `request` parameter to `ArcGisImageServerImageryProvider.buildImageResource` - this enables Cesium to manage requests
+- Decrease protomaps tile buffer to 32 pixels (from 64) to increase performance
+- Change `ProtomapsImageryProvider` to use a "soft" minimum level, so all tiles will be blank below the `minimumZoom` provided.
+- Move `ProtomapsImageryProvider.pickFeatures` GeoJSON logic to inside `ProtomapsGeojsonSource.pickFeatures`.
+- Fix `FeatureInfoUrlTemplateMixin` reactivity warnings
+- Move `GeojsonMixin` protomaps paint/label rules to `tableStyleToProtomaps`.
+  - Also create `getStyleReactiveDependencies` that can be used to track (and react to) table styling traits
+- Add `dash` to `OutlineStyleTraits` (only supported by line features), and `outlineStyle` to `LegendTraits`.
+- Add `MinMaxLevelMixin` to `ArcGisFeatureServerCatalogItem` - only applied when tiling requests
+- Tweaked `TableStyleMap` and `TableColorMap` conditions to handle empty `TableColumns` (to support styling `ArcGisFeatureServerCatalogItem` when tiling requests)
 - [The next improvement]
 
 #### 8.7.11 - 2024-12-18

lib/Core/TypeModifiers.ts

@@ -41,6 +41,8 @@ export type CopyNullAndUndefined<TSource, TTarget> = If<
  */
 export type NotUndefined<T> = T extends undefined ? never : T;
 
+export type NotNull<T> = T extends null ? never : T;
+
 /**
  * Makes all properties required to be present. Any that were previously optional are
  * allowed to be undefined.

lib/Map/ColorMap/ColorMap.ts

@@ -1,7 +1,6 @@
 import Color from "terriajs-cesium/Source/Core/Color";
+import JsonValue from "../../Core/Json";
 
 export default abstract class ColorMap {
-  abstract mapValueToColor(
-    value: string | number | null | undefined
-  ): Readonly<Color>;
+  abstract mapValueToColor(value: JsonValue | undefined): Readonly<Color>;
 }

lib/Map/ImageryProvider/ArcGisImageServerImageryProvider.ts

@@ -8,6 +8,7 @@ import GeographicProjection from "terriajs-cesium/Source/Core/GeographicProjecti
 import GeographicTilingScheme from "terriajs-cesium/Source/Core/GeographicTilingScheme";
 import Math from "terriajs-cesium/Source/Core/Math";
 import Rectangle from "terriajs-cesium/Source/Core/Rectangle";
+import Request from "terriajs-cesium/Source/Core/Request";
 import Resource from "terriajs-cesium/Source/Core/Resource";
 import TilingScheme from "terriajs-cesium/Source/Core/TilingScheme";
 import DiscardMissingTileImagePolicy from "terriajs-cesium/Source/Scene/DiscardMissingTileImagePolicy";
@@ -123,10 +124,11 @@ export default class ArcGisImageServerImageryProvider {
     return this.baseResource.proxy;
   }
 
-  buildImageResource(x: number, y: number, level: number) {
+  buildImageResource(x: number, y: number, level: number, request?: Request) {
     if (this.usePreCachedTiles) {
       return this.baseResource.getDerivedResource({
-        url: `tile/${level}/${y}/${x}`
+        url: `tile/${level}/${y}/${x}`,
+        request: request
       });
     } else {
       const nativeRectangle = this.tilingScheme.tileXYToNativeRectangle(
@@ -154,7 +156,8 @@ export default class ArcGisImageServerImageryProvider {
 
       return this.baseResource.getDerivedResource({
         url: "exportImage",
-        queryParameters: query
+        queryParameters: query,
+        request: request
       });
     }
   }
@@ -163,10 +166,10 @@ export default class ArcGisImageServerImageryProvider {
     return [];
   }
 
-  requestImage(x: number, y: number, level: number): any {
+  requestImage(x: number, y: number, level: number, request: Request): any {
     return ImageryProvider.loadImage(
       this,
-      this.buildImageResource(x, y, level)
+      this.buildImageResource(x, y, level, request)
     );
   }