fix(keys): initially focus the key log #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `textual keys`, currently the 'Clear' button will have initial focus. This can be confusing if you're trying to test the `enter` key with some modifiers, as this might invoke a button press! This simply re-orders the composed widgets so the key log is initially focussed instead.
|
I would have gone with |
|
Sure, that also works, but why? This does the same thing and reflects the order of the widgets as they are displayed. |
|
I think the addition of the classvar makes it more explicit which is focused, but honestly I'm not fussed either way... |
willmcgugan
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
textual keys, currently the 'Clear' button will have initial focus. This can be confusing if you're trying to test theenterkey with some modifiers, as this might invoke a button press!This simply re-orders the composed widgets so the key log is initially focussed instead.