Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MaskedInput selection replace with invalid value #5494

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion src/textual/widgets/_masked_input.py
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def insert_separators(self, value: str, cursor_position: int) -> tuple[str, int]
cursor_position += 1
return value, cursor_position

def insert_text_at_cursor(self, text: str) -> str | None:
def insert_text_at_cursor(self, text: str) -> tuple[str, int] | None:
"""Inserts `text` at current cursor position. If not present in `text`, any expected separator is automatically
inserted at the correct position.

Expand Down Expand Up @@ -610,6 +610,37 @@ def insert_text_at_cursor(self, text: str) -> None:
else:
self.restricted()

def replace(self, text: str, start: int, end: int):
"""Replace the text between the start and end locations with the given text.

Args:
text: Text to replace the existing text with.
start: Start index to replace (inclusive).
end: End index to replace (inclusive).
"""

self.cursor_position = start
# Handle case where cursor start on a separator
self._template.move_cursor(1)
self._template.move_cursor(-1)
if self.cursor_position < start:
self._template.move_cursor(1)

for char in text:
if self.cursor_position >= end:
return
new_value_cursor_position = self._template.insert_text_at_cursor(char)
if new_value_cursor_position is None:
self.restricted()
return
self.value, self.cursor_position = new_value_cursor_position

last_cursor_position = self.cursor_position
while self.cursor_position < min(end, len(self.value)):
self._template.delete_at_position()
self._template.move_cursor(1)
self.cursor_position = last_cursor_position

def clear(self) -> None:
"""Clear the masked input."""
self.value, self.cursor_position = self._template.insert_separators("", 0)
Expand Down