App query change #5562
Merged
App query change #5562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darrenburns Any thoughts on this one? |
|
I think this is a better approach! |
|
On hold for a future major bump. I'm expecting at least one more bug fix release in the interim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully fixes a common gotcha.
Previously when you do
app.queryit will query the active screen. This is completely reasonable from a definitional POV. But it is a frequent source of confusion because when you push a screen, previously working queries now fail.This change ensures that
app.queryqueries the screen that was composed by the App itself, i.e. the default screen. So it always queries the same screen. If you do want to query the current screen it is as simple asapp.screen.query.This shouldn't impact many apps, because as soon as devs run in to the query broken by push_screen gotcha, we advise them to be explicit about screens anyway.