-
Notifications
You must be signed in to change notification settings - Fork 906
don't call get_event_loop() if it's deprecated, handle RuntimeError from get_event_loop after asyncio.run #5799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
willmcgugan
merged 8 commits into
Textualize:main
from
graingert:fix-get-event-loop-call
May 31, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b9afd28
don't call get_event_loop() if it's deprecated
graingert 2494598
handle RuntimeError in get_event_loop after asyncio.run
graingert e878a8a
update CHANGELOG
graingert 7e412cf
apply black
graingert 5d9e3c0
Merge branch 'main' into fix-get-event-loop-call
graingert bc96aac
move eagerly created asyncio.Event and asyncio.Queue objects into cac…
graingert a5ce9bb
cite cached_property
graingert 3de7196
Merge branch 'main' into fix-get-event-loop-call
graingert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
from __future__ import annotations | ||
|
||
import sys | ||
from typing import Any, Generic, TypeVar, overload | ||
|
||
if sys.version_info >= (3, 12): | ||
from functools import cached_property | ||
else: | ||
# based on the code from Python 3.14: | ||
# https://github.com/python/cpython/blob/ | ||
# 5507eff19c757a908a2ff29dfe423e35595fda00/Lib/functools.py#L1089-L1138 | ||
# Copyright (C) 2006 Python Software Foundation. | ||
# vendored under the PYTHON SOFTWARE FOUNDATION LICENSE VERSION 2 because | ||
# prior to Python 3.12 cached_property used a threading.Lock, which makes | ||
# it very slow. | ||
_T_co = TypeVar("_T_co", covariant=True) | ||
_NOT_FOUND = object() | ||
|
||
class cached_property(Generic[_T_co]): | ||
def __init__(self, func: Callable[[Any, _T_co]]) -> None: | ||
self.func = func | ||
self.attrname = None | ||
self.__doc__ = func.__doc__ | ||
self.__module__ = func.__module__ | ||
|
||
def __set_name__(self, owner: type[any], name: str) -> None: | ||
if self.attrname is None: | ||
self.attrname = name | ||
elif name != self.attrname: | ||
raise TypeError( | ||
"Cannot assign the same cached_property to two different names " | ||
f"({self.attrname!r} and {name!r})." | ||
) | ||
|
||
@overload | ||
def __get__(self, instance: None, owner: type[Any] | None = None) -> Self: ... | ||
|
||
@overload | ||
def __get__( | ||
self, instance: object, owner: type[Any] | None = None | ||
) -> _T_co: ... | ||
|
||
def __get__( | ||
self, instance: object, owner: type[Any] | None = None | ||
) -> _T_co | Self: | ||
if instance is None: | ||
return self | ||
if self.attrname is None: | ||
raise TypeError( | ||
"Cannot use cached_property instance without calling __set_name__ on it." | ||
) | ||
try: | ||
cache = instance.__dict__ | ||
except ( | ||
AttributeError | ||
): # not all objects have __dict__ (e.g. class defines slots) | ||
msg = ( | ||
f"No '__dict__' attribute on {type(instance).__name__!r} " | ||
f"instance to cache {self.attrname!r} property." | ||
) | ||
raise TypeError(msg) from None | ||
val = cache.get(self.attrname, _NOT_FOUND) | ||
if val is _NOT_FOUND: | ||
val = self.func(instance) | ||
try: | ||
cache[self.attrname] = val | ||
except TypeError: | ||
msg = ( | ||
f"The '__dict__' attribute on {type(instance).__name__!r} instance " | ||
f"does not support item assignment for caching {self.attrname!r} property." | ||
) | ||
raise TypeError(msg) from None | ||
return val |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.