fix: Highlighter isSetup # 556 #574
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade three to 0.170 at: packages/core When tried to update at 0.174.0 or 0.170.0 errors for importing WebGLMultipleRenderTargets and Controls came up. Hence, 0.170.0 was selected. Also, only packages/core were updated. For packages/front there may be a need to a separate issue as I think at the moment they do not support a later revision. Reviewed-by: Goulielmos Floros Refs: ThatOpen#564
Added isSetup equals to false for the async function when you dispose the highlighter. Therefore if whenever you specify highlighter.dispose() every time you switch pages the isSetup becomes false. Reviewed-by: Goulielmos Floros Ref: ThatOpen#556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added isSetup equals to false for the async function when you dispose the highlighter. Therefore if whenever you specify highlighter.dispose() every time you switch pages the isSetup becomes false.
Reviewed-by: Goulielmos Floros
Ref: #556
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).