Skip to content

docs: fix broken link to the license file #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Apr 7, 2024

Description

Related to #154.

Fixes the link to the license. Please notice that I decided to leave the absolute path. I am not sure what it the legal point of view, but it somehow makes sense that each fork and branch is under the same license.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing checks pass.
  • No plagiarized, duplicated, or repetitive documentation that has been directly copied from another source.
  • If it's a new explanation, it contains solid, understandable, and accessible information.
  • I have read the whole contributing guidelines and agree to the Code of Conduct.

Screenshots (if any)

Note to reviewers

@vil02 vil02 marked this pull request as ready for review April 7, 2024 19:41
appgurueu
appgurueu previously approved these changes Apr 7, 2024
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a relative path would make slightly more sense though (say someone clones or forks this). If we were to change our license, or if the forking person was to change the license (of course in a compatible manner) that should not cause any issues.

@appgurueu appgurueu merged commit f76f185 into TheAlgorithms:master Apr 8, 2024
4 checks passed
@vil02 vil02 deleted the link_to_license branch April 8, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants