Skip to content

Add round-robin CPU scheduling algorithm #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 26 commits into from
Closed

Add round-robin CPU scheduling algorithm #2193

wants to merge 26 commits into from

Conversation

Daemon19
Copy link
Contributor

@Daemon19 Daemon19 commented Oct 9, 2022 •
edited
Loading

Description of Change

Create round_robin_scheduling.cpp file in cpu_scheduling_algorithms directory. #2024 #1574

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Daemon19 Daemon19 force-pushed the round-robin-scheduling branch from eababa8 to 803d707 Compare October 9, 2022 03:48
@Daemon19 Daemon19 marked this pull request as ready for review October 9, 2022 03:49
@Daemon19 Daemon19 changed the title feat: Create round-robin CPU scheduling algorithm Create round-robin CPU scheduling algorithm Oct 9, 2022
@Daemon19 Daemon19 changed the title Create round-robin CPU scheduling algorithm Add round-robin CPU scheduling algorithm Oct 9, 2022
@Daemon19 Daemon19 marked this pull request as draft October 9, 2022 03:51
@Daemon19 Daemon19 marked this pull request as ready for review October 9, 2022 06:57
@mishraabhinn mishraabhinn added good first issue Good for newcomers awaiting modification Do not merge until modifications are made labels Oct 9, 2022
@Daemon19 Daemon19 requested a review from mishraabhinn October 10, 2022 12:13
mahatma21
mahatma21 previously approved these changes Oct 18, 2022
View reviewed changes
@Panquesito7 Panquesito7 added enhancement New feature or request and removed good first issue Good for newcomers labels Oct 18, 2022
Panquesito7
Panquesito7 requested changes Oct 18, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/Daemon19/C-Plus-Plus/actions

@Panquesito7 Panquesito7 added automated tests are failing Do not merge until tests pass requested changes changes have been requested labels Oct 18, 2022
@Daemon19 Daemon19 requested a review from Panquesito7 October 18, 2022 11:50
Daemon19
Daemon19 commented Oct 20, 2022
View reviewed changes
Copy link
Contributor Author

@Daemon19 Daemon19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change that file in this pull request?

@Panquesito7
Copy link
Member

Panquesito7 commented Oct 20, 2022 •
edited
Loading

Why did you change that file in this pull request?

That was changed automatically by the CI.
It looks as if I've made changes. We've made that to ensure commits are pushed through protected branches, which a GitHub Actions user/workflow normally cannot do.

Panquesito7
Panquesito7 requested changes Oct 20, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! :)

@Panquesito7 Panquesito7 removed the awaiting modification Do not merge until modifications are made label Oct 20, 2022
@github-actions github-actions bot force-pushed the round-robin-scheduling branch from 94edaf6 to d08022c Compare October 20, 2022 22:27
@Daemon19 Daemon19 requested review from Panquesito7 and mishraabhinn and removed request for Panquesito7 and mishraabhinn October 21, 2022 09:29
Panquesito7
Panquesito7 reviewed Jan 1, 2023
View reviewed changes
cpu_scheduling_algorithms/round_robin_scheduling.cpp
Comment on lines +27 to +29
uint32_t id; ///< Used to distinguish processes
uint32_t arrival_time; ///< The time at which the process arrives
uint32_t burst_time; ///< Time required to complete process execution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to initialize the variables to avoid issues.

Suggested change
uint32_t id; ///< Used to distinguish processes
uint32_t arrival_time; ///< The time at which the process arrives
uint32_t burst_time; ///< Time required to complete process execution
uint32_t id = 0; ///< Used to distinguish processes
uint32_t arrival_time = 0; ///< The time at which the process arrives
uint32_t burst_time = 0; ///< Time required to complete process execution

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Feb 1, 2023
@Panquesito7 Panquesito7 removed the stale Author has not responded to the comments for over 2 weeks label Feb 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Mar 3, 2023
@github-actions
Copy link
Contributor

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 requested changes

@mishraabhinn mishraabhinn mishraabhinn requested changes

@mahatma21 mahatma21 mahatma21 left review comments

Assignees
No one assigned
Labels
automated tests are failing Do not merge until tests pass enhancement New feature or request requested changes changes have been requested stale Author has not responded to the comments for over 2 weeks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Daemon19 @Panquesito7 @mishraabhinn @mahatma21