test: add additional test cases for FindIndex method in FastSearcher#578
Merged
test: add additional test cases for FindIndex method in FastSearcher#578
Conversation
Member
siriak
commented
Nov 16, 2025
- I have performed a self-review of my code
- My code follows the style guidelines of this project
- I have added tests that prove my fix is effective or that my feature works
- New and existing unit tests pass locally with my changes
- Comments in areas I changed are up to date
- I have added comments to hard-to-understand areas of my code
- I have made corresponding changes to the README.md
Member
Author
|
Fixes #572 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the FindIndex method in FastSearcher by introducing a new test method with multiple test cases that cover various scenarios of the hybrid binary-interpolation search algorithm.
Key changes:
- Added 10 new deterministic test cases covering edge cases and different distributions
- Tests specifically target the algorithm's behavior with left/right segments, boundary conditions, and various data distributions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #578 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 300 300
Lines 12598 12598
Branches 1842 1842
=======================================
Hits 12216 12216
Misses 242 242
Partials 140 140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.