Skip to content

fix: throw error instead of returning it in check case type functions #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion String/CheckFlatCase.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
const checkFlatCase = (varname) => {
// firstly, check that input is a string or not.
if (typeof varname !== 'string') {
return new TypeError('Argument is not a string.')
throw new TypeError('Argument is not a string.')
}

const pat = /^[a-z]*$/
Expand Down
2 changes: 1 addition & 1 deletion String/CheckKebabCase.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
const CheckKebabCase = (varName) => {
// firstly, check that input is a string or not.
if (typeof varName !== 'string') {
return new TypeError('Argument is not a string.')
throw new TypeError('Argument is not a string.')
}

const pat = /(\w+)-(\w)([\w-]*)/
Expand Down
2 changes: 1 addition & 1 deletion String/CheckPascalCase.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
const CheckPascalCase = (VarName) => {
// firstly, check that input is a string or not.
if (typeof VarName !== 'string') {
return new TypeError('Argument is not a string.')
throw new TypeError('Argument is not a string.')
}

const pat = /^[A-Z][A-Za-z]*$/
Expand Down
4 changes: 4 additions & 0 deletions String/test/CheckCamelCase.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,8 @@ describe('checkCamelCase', () => {
const result = checkCamelCase(value)
expect(result).toBe(false)
})

it('should throw when input is not a string', () => {
expect(() => checkCamelCase(100)).toThrowError()
})
})
4 changes: 4 additions & 0 deletions String/test/CheckFlatCase.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,8 @@ describe('checkFlatCase function', () => {
const actual = checkFlatCase('abcdefghijklmnopqrstuvwxyz')
expect(actual).toBe(true)
})

it('should throw when input is not a string', () => {
expect(() => checkFlatCase(100)).toThrowError()
})
})
4 changes: 4 additions & 0 deletions String/test/CheckKebabCase.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,7 @@ test('CheckKebabCase(The Algorithms) -> false', () => {
const res = CheckKebabCase(word)
expect(res).toBeFalsy()
})

test('CheckKebabCase throws when input is not a string', () => {
expect(() => CheckKebabCase(100)).toThrowError()
})
4 changes: 4 additions & 0 deletions String/test/CheckPascalCase.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,7 @@ test('CheckPascalCase(The Algorithms) -> false', () => {
const res = CheckPascalCase(word)
expect(res).toBeFalsy()
})

test('CheckPascalCase throws when input is not a string', () => {
expect(() => CheckPascalCase(100)).toThrowError()
})