Create and populate the Maths directory #4

dlesnoff · 2023-03-14T13:41:19Z

Add:

maths/ directory
aliquot_sum.nim
addition_without_arithmetic.nim
abs.nim
~~allocation_number.nim~~

These are examples adapted into Nim from TheAlgorithms/Python/maths.

I will rebase from master to remove Contributing Guidelines and all these other stuffs when my other PR will be merged.
I tried to respect:
{.push raises: [].} pragma on top of the file
use of Natural(s) to limit exceptions -> might be improved by Positive type?
use of Slices instead of Python tuples for ranges
runnableExamples on top to showcase the functions of the module
unittest under a when isMainModule block at the end

I respected also these but these are my personal conventions:

~~I do not export by default my functions.~~
~~I do not put a newline at the end of my files~~

ZoomRmc

Looks splendid!

maths/aliquot_sum.nim

maths/abs.nim

pietroppeter

this is good thanks! my guess is you picked the first few files in alphabetical order from python repo? ;) there are some uncommon algorithms there (and my suggestion would be to skip allocation_number). :)

maths/addition_without_arithmetic.nim

maths/aliquot_sum.nim

maths/allocation_number.nim

Co-authored-by: Zoom <[email protected]>

Co-authored-by: Pietro Peterlongo <[email protected]>

dlesnoff · 2023-04-25T14:59:13Z

I added empty lines at end of files as requested by @Panquesito7 in another PR.

dlesnoff · 2023-06-19T20:16:52Z

@ZoomRmc I just need one approving review to merge this old pull request.

maths/aliquot_sum.nim

maths/bitwise_addition.nim

ZoomRmc

abs.nim requires a few changes to make runnableExamples compile:

export all used procs
replace absMaxSort with the updated name signedMaxAbs
You can also add a signedMinAbs test there, while you're editing it.

BTW, IIRC, runnableExamples are compiled as debug by default (or always?), so a regular assert works in them just fine. Nothing wrong with doAssert too, of course. Just a tip.

Co-authored-by: Zoom <[email protected]>

dlesnoff

Remove quotation marks for MD inline code (without opening my editor ~~since I am lazy~~).

maths/abs.nim

maths/aliquot_sum.nim

ZoomRmc · 2023-06-19T22:40:28Z

I think the RE block in abs.nim is the last thing to fix, and then it looks ready to merge!

dlesnoff · 2023-06-20T10:02:09Z

nim -ax r aliquot_sum.nim made me realize there was a supplementary ValueError declaration to the exception system.
Thanks for your suggestion changes, I finally opened my editor and applied them ;)

ZoomRmc

Nicely done!

It was interesting to see the code evolve to conform to the newly written guidelines :)

edit: My review is not enough, perhaps because of the codeowners? Or because you requested particular reviewers, not sure.

dlesnoff · 2023-06-20T10:34:12Z

@pietroppeter You requested changes, that might block the PR. If you are still around, can you accept the PR, to see if that's what is blocking the PR?
@Panquesito7 I think that you dimissed the review of @ZoomRmc and that merging requires your approval. (At least, as a code owner, you can resolve the situation no matter the old requested changes from @pietroppeter ).

dlesnoff · 2023-06-20T11:59:07Z

Looks like it requires @Panquesito7 's approval nonetheless.

Panquesito7 · 2023-06-23T20:14:08Z

Looks like it requires @Panquesito7 's approval nonetheless.

It requires approval from someone with write+ access.
There are not many maintainers currently. If someone wants to apply: #9

dlesnoff · 2023-06-23T20:25:45Z

Thanks @Panquesito7 !

* Add a sample of maths basic algorithms * Update maths/abs.nim Co-authored-by: Zoom <[email protected]> * Use openArray in absMaxSort Co-authored-by: Zoom <[email protected]> * Fix seq->openArray and int->SomeInteger * Use Positive as input instead * Update maths/addition_without_arithmetic.nim Co-authored-by: Pietro Peterlongo <[email protected]> * Name allocation number * [maths/abs] Replace maxAbsSort by signed[Min/Max]Abs * [Aliquot Sum] Add header * Add empty line at end of file * Remove Allocation number since it is a non standard algorithm * Fix titles * Run nimpretty on the files * Rename file and add DIRECTORY.md * abs: Fix variable name * Add export marker Co-authored-by: Zoom <[email protected]> * Add RE block in aliquot sum and improve RE Co-authored-by: Zoom <[email protected]> * Remove MD quotation marks for inline code * Add export marker for RE block * Remove extra ValueError --------- Co-authored-by: Dimitri LESNOFF <[email protected]> Co-authored-by: Zoom <[email protected]> Co-authored-by: Pietro Peterlongo <[email protected]> Co-authored-by: David Leal <[email protected]>

* Add a .github action to build DIRECTORY.md * Update gh action build_directory_md * Add ignored paths and git credentials * chore: minor Gitpod improvements (#34) Add Gitpod badge and prebuilds for all branches and forks * Add binary search (#37) * Add binary search * Update binary search: add recursive version * Update binary search: better description * Update binary search: update runnableExamples * Update binary search: improve tests, add overload for recursive func * Update binary search: evaluate if-expression into result * grammar * Update binary search: improve description, add comments * Update binary search: add missing test cases * Update binary search: add info about pivot choice in description, rearrange it * Update binary search: change int to Natural * Update binary search: if block -> guard clause * Update binary search: test cases * Update binary search: simplify docs * Update binary search: nimpretty * Apply suggestions from code review Co-authored-by: David Leal <[email protected]> * Replace by an attempt of github pr create * Fix branching and environment variable in the PR Co-authored-by: David Leal <[email protected]> * Create and populate the Maths directory (#4) * Add a sample of maths basic algorithms * Update maths/abs.nim Co-authored-by: Zoom <[email protected]> * Use openArray in absMaxSort Co-authored-by: Zoom <[email protected]> * Fix seq->openArray and int->SomeInteger * Use Positive as input instead * Update maths/addition_without_arithmetic.nim Co-authored-by: Pietro Peterlongo <[email protected]> * Name allocation number * [maths/abs] Replace maxAbsSort by signed[Min/Max]Abs * [Aliquot Sum] Add header * Add empty line at end of file * Remove Allocation number since it is a non standard algorithm * Fix titles * Run nimpretty on the files * Rename file and add DIRECTORY.md --------- Co-authored-by: Dimitri LESNOFF <[email protected]> Co-authored-by: David Leal <[email protected]> * Add arc length (#10) * Fix linear search (#33) * Use a dynamic allocated array (sequence) for strings * Run nimpretty * Add requested changes * Fix documentation generation * Fix test title according to changes Co-authored-by: Satin Wuker <[email protected]> * Update comments to warn about indexing issues Modified a bit the suggestions of comments. Please check them before approving. Co-authored-by: Zoom <[email protected]> --------- Co-authored-by: Dimitri LESNOFF <[email protected]> Co-authored-by: Zoom <[email protected]> * chore: run `apt-get update` before running other commands (#41) This will run `sudo apt-get update` before running any other commands on the Gitpod prebuild image (`.gitpod.dockerfile`). * Readme: fix gitter link, add Nim logo, formatting fixes (#42) * Update README.md Use more extended markdown syntax instead of HTML, Add Matrix links Superseed PR #40 * Actually fix gitter! Move img src links to footer. Also changed the TheAlgorithms logo image link. * Restore TheAlgorithms logo link * More link fixes --------- Co-authored-by: dlesnoff <[email protected]> * fix: nimpretty for `arc_length.nim` (#43) * chore: `gc`->`mm`, move back to `config.nims` (#47) * chore: revert #41 (#45) * Update codeowners * Fix: CONTRIBUTING.md links (#49) Uppercase `directory.md` to `DIRECTORY.md` * feat: add Levenshtein distance (#46) * feat: add Levenshtein distance * Apply suggestions from code review Co-authored-by: Zoom <[email protected]> * refactor: use toKey in initSubsolutions * style: use .Natural * style: remove blank line * refactor: add Key type * style: use descriptive variable names * style: use a, b instead of strA, strB * docs: add note about complexity * refator: add name to TestCase * docs: remove sentence about dp * docs: update documentation of `levenshteinDistance` Co-authored-by: Zoom <[email protected]> * docs: rename initLevenshteinDistanceMatrix and add its documentation * refactor: add fillLevenshteinDistanceMatrix * tests: reorganise tests, remove TestCase type * docs: add edit distance to module-level documentation * docs: mention Wagner–Fischer algorithm * docs: add comment in fillLevenshteinDistanceMatrix * style: reformat fillLevenshteinDistanceMatrix * docs: update DIRECTORY.md --------- Co-authored-by: Zoom <[email protected]> * docs: add missing `#` (#50) * docs: add missing `#` * docs: update DIRECTORY.md * docs: remove ` of a Circle` * docs: update DIRECTORY.md --------- Co-authored-by: dlesnoff <[email protected]> * Fix: Remove unuseful date command * chore: Update checkout version to v4 in build_directory_md * Add error status checking + separate compilation and execution of directory.nim --------- Co-authored-by: Dimitri LESNOFF <[email protected]> Co-authored-by: David Leal <[email protected]>

ZoomRmc suggested changes Mar 16, 2023

View reviewed changes

maths/aliquot_sum.nim Outdated Show resolved Hide resolved

maths/abs.nim Outdated Show resolved Hide resolved

maths/abs.nim Outdated Show resolved Hide resolved

maths/abs.nim Outdated Show resolved Hide resolved

dlesnoff force-pushed the maths branch from da7aa3b to 74ec13a Compare March 17, 2023 15:38

pietroppeter suggested changes Mar 23, 2023

View reviewed changes

maths/addition_without_arithmetic.nim Outdated Show resolved Hide resolved

maths/aliquot_sum.nim Outdated Show resolved Hide resolved

maths/allocation_number.nim Outdated Show resolved Hide resolved

Panquesito7 added the enhancement New feature or request label Mar 24, 2023

dlesnoff and others added 7 commits March 25, 2023 00:53

Add a sample of maths basic algorithms

5841dbc

Update maths/abs.nim

2e1b30c

Co-authored-by: Zoom <[email protected]>

Use openArray in absMaxSort

ec85c68

Co-authored-by: Zoom <[email protected]>

Fix seq->openArray and int->SomeInteger

3abe706

Use Positive as input instead

934cc5a

Update maths/addition_without_arithmetic.nim

682b540

Co-authored-by: Pietro Peterlongo <[email protected]>

Name allocation number

1bf1707

dlesnoff force-pushed the maths branch from 39f28bd to 1bf1707 Compare March 24, 2023 23:53

[maths/abs] Replace maxAbsSort by signed[Min/Max]Abs

dbf73d7

ZoomRmc previously approved these changes Apr 24, 2023

View reviewed changes

[Aliquot Sum] Add header

d88cc3c

Panquesito7 requested a review from pietroppeter April 24, 2023 19:30

dlesnoff and others added 2 commits April 25, 2023 16:56

Merge branch 'main' into maths

b2b350d

Add empty line at end of file

9c76b50

Panquesito7 dismissed ZoomRmc’s stale review via 9c76b50 April 26, 2023 16:31

dlesnoff added 5 commits June 19, 2023 21:55

Merge branch 'main' into maths

1653ad0

Remove Allocation number since it is a non standard algorithm

b86c2ef

Fix titles

89feb5d

Run nimpretty on the files

26255f8

Rename file and add DIRECTORY.md

05ca7bf

dlesnoff requested a review from Panquesito7 as a code owner June 19, 2023 20:04

abs: Fix variable name

2605811

ZoomRmc suggested changes Jun 19, 2023

View reviewed changes

maths/aliquot_sum.nim Outdated Show resolved Hide resolved

maths/bitwise_addition.nim Outdated Show resolved Hide resolved

ZoomRmc suggested changes Jun 19, 2023

View reviewed changes

dlesnoff and others added 2 commits June 19, 2023 23:27

Add export marker

f13593e

Co-authored-by: Zoom <[email protected]>

Add RE block in aliquot sum and improve RE

512c6bf

Co-authored-by: Zoom <[email protected]>

dlesnoff commented Jun 19, 2023

View reviewed changes

Remove MD quotation marks for inline code

b8e0c8d

dlesnoff added 2 commits June 20, 2023 11:45

Add export marker for RE block

3cf3fdf

Remove extra ValueError

e6cf67a

ZoomRmc approved these changes Jun 20, 2023

View reviewed changes

dlesnoff removed request for pietroppeter and Panquesito7 June 20, 2023 10:26

ZoomRmc approved these changes Jun 20, 2023

View reviewed changes

pietroppeter approved these changes Jun 20, 2023

View reviewed changes

Merge branch 'main' into maths

09a66e3

Panquesito7 approved these changes Jun 23, 2023

View reviewed changes

Merge branch 'main' into maths

979f9ff

Panquesito7 merged commit cf013f1 into TheAlgorithms:main Jun 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create and populate the Maths directory #4

Create and populate the Maths directory #4

dlesnoff commented Mar 14, 2023 •

edited

Loading

ZoomRmc left a comment

pietroppeter left a comment

dlesnoff commented Apr 25, 2023

dlesnoff commented Jun 19, 2023 •

edited

Loading

ZoomRmc left a comment

dlesnoff left a comment •

edited

Loading

ZoomRmc commented Jun 19, 2023

dlesnoff commented Jun 20, 2023

ZoomRmc left a comment •

edited

Loading

dlesnoff commented Jun 20, 2023

dlesnoff commented Jun 20, 2023

Panquesito7 commented Jun 23, 2023

dlesnoff commented Jun 23, 2023

Create and populate the Maths directory #4

Create and populate the Maths directory #4

Conversation

dlesnoff commented Mar 14, 2023 • edited Loading

ZoomRmc left a comment

Choose a reason for hiding this comment

pietroppeter left a comment

Choose a reason for hiding this comment

dlesnoff commented Apr 25, 2023

dlesnoff commented Jun 19, 2023 • edited Loading

ZoomRmc left a comment

Choose a reason for hiding this comment

dlesnoff left a comment • edited Loading

Choose a reason for hiding this comment

ZoomRmc commented Jun 19, 2023

dlesnoff commented Jun 20, 2023

ZoomRmc left a comment • edited Loading

Choose a reason for hiding this comment

dlesnoff commented Jun 20, 2023

dlesnoff commented Jun 20, 2023

Panquesito7 commented Jun 23, 2023

dlesnoff commented Jun 23, 2023

dlesnoff commented Mar 14, 2023 •

edited

Loading

dlesnoff commented Jun 19, 2023 •

edited

Loading

dlesnoff left a comment •

edited

Loading

ZoomRmc left a comment •

edited

Loading