Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update actions/checkout to v4 #58

Merged
merged 2 commits into from
Sep 7, 2023
Merged

chore: update actions/checkout to v4 #58

merged 2 commits into from
Sep 7, 2023

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Sep 4, 2023 •
edited
Loading

The actions/checkout@v4 was recently released.

@vil02 vil02 marked this pull request as ready for review September 4, 2023 16:38
@vil02 vil02 requested a review from Panquesito7 as a code owner September 4, 2023 16:38
@vil02
Copy link
Member Author

vil02 commented Sep 4, 2023

@Panquesito7 could you please rerun the failing nim_test / nim_test (windows-latest, 2.0.0)? I guess it is some random failure. It passes on my end (cf. raw log).

@dlesnoff
Copy link
Collaborator

dlesnoff commented Sep 7, 2023

This looks like a GitHub random failure indeed.
If you push a commit (with some cosmetic change?), it should relaunch the tests and hopefully these will pass.
Thanks for maintaining this repository!

@dlesnoff dlesnoff mentioned this pull request Sep 7, 2023
Merged
3 tasks
@vil02
Copy link
Member Author

vil02 commented Sep 7, 2023

If you push a commit (with some cosmetic change?), it should relaunch the tests and hopefully these will pass.

@dlesnoff I did not want to introduce some redundant commit. There is a possibility to simply rerun jobs without any hacky magic.

Thanks for maintaining this repository!

Pleasure!

@dlesnoff
Copy link
Collaborator

dlesnoff commented Sep 7, 2023

@vil02 Thanks for the information. Turns out, I can also rerun jobs.
I have been granted the status of maintainer of this repository, you can ask for it too: see issue #9 !

dlesnoff
dlesnoff approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@dlesnoff dlesnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@dlesnoff dlesnoff merged commit c9c8077 into TheAlgorithms:main Sep 7, 2023
@vil02 vil02 deleted the use_checkout_action_v4 branch September 7, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlesnoff dlesnoff dlesnoff approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vil02 @dlesnoff