Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create python-package.yml #12015

Closed
wants to merge 1 commit into from
Closed

Create python-package.yml #12015

wants to merge 1 commit into from

Conversation

Kishore0-0-7
Copy link

@Kishore0-0-7 Kishore0-0-7 commented Oct 12, 2024 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@Kishore0-0-7 Kishore0-0-7 requested a review from cclauss as a code owner October 12, 2024 17:16
@algorithms-keeper
Copy link

Closing this pull request as invalid

@Kishore0-0-7, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper bot removed the request for review from cclauss October 12, 2024 17:16
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 12, 2024
@cclauss
Copy link
Member

cclauss commented Oct 12, 2024

We really do not need this. Our GitHub Actions are more sophisticated and tailored to our codebase.

cclauss
cclauss reviewed Oct 12, 2024
View reviewed changes
.github/workflows/python-package.yml
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install flake8 pytest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use ruff which is a faster superset of flake8.

cclauss
cclauss reviewed Oct 12, 2024
View reviewed changes
.github/workflows/python-package.yml
steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v5

@cclauss
Copy link
Member

cclauss commented Oct 12, 2024

Start with a current version…

https://docs.github.com/en/actions/use-cases-and-examples/building-and-testing/building-and-testing-python

github/docs#24401

@Kishore0-0-7
Copy link
Author

unlock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kishore0-0-7 @cclauss