Implemented Texture Icons/Thumbnails#595
Open
PrakarshPanwar wants to merge 9 commits intoTheCherno:masterfrom
Open
Implemented Texture Icons/Thumbnails#595PrakarshPanwar wants to merge 9 commits intoTheCherno:masterfrom
PrakarshPanwar wants to merge 9 commits intoTheCherno:masterfrom
Conversation
- Earlier textures were represented by Standard File Icon - Now only .png will be presented as texture in Content Browser Panel
…operties panel - Now on clicking on Entity will show texture in a button
- Also removed some previous methods and made default texture in SceneHierarchyPanel const - Editor crashes when adding new textures in asset directory
- This will help in distinguish Scene names
- This issue is still open to some extent - This can happen due to OpenGL unable to load multiple textures at once - This issue will gone after switching to Vulkan
- Reason for this issue was that the texture didn't load fully on the directory which resulted in black textures - Adding `std.this_thread.sleep_for` gave time for directory to load textures properly - However for large assets that can take longer than 0.02s to load on directory this method will not work
# Conflicts: # Hazelnut/src/Panels/ContentBrowserPanel.cpp
- To do this right-click on Image Button in SpriteRendererComponent then click Remove Texture
PrakarshPanwar
force-pushed
the
thumbnails
branch
from
b9da860 to
d6b6f06
Compare
- Now instead of taking `this` it only takes default texture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue (if no issue has been made)
ContentBrowserPanelfor Texture Files, it is represented by Standard File IconSpriteRendererComponentin Properties Panel, there is onlyTexturedrag/drop button and not an Image Button IconPR impact (Make sure to add closing keywords)
List of related issues/PRs this will solve:
ContentBrowserPanelImGui.ImageButtoninstead ofImGui.Buttonfor Texture inSpriteRendererComponentin Properties Panel. To remove texture right-click on Image Button then click Remove TextureProposed fix (Make sure you've read on how to contribute to Hazel)
A short description of what this fix is and how it fixed the issue you described.
Additional context
std.unordered_mapcache. Possible solution is to use filewatcher