Fixed unresponsive ui during window resize#633
Open
zod24 wants to merge 1 commit intoTheCherno:masterfrom
Open
Fixed unresponsive ui during window resize#633zod24 wants to merge 1 commit intoTheCherno:masterfrom
zod24 wants to merge 1 commit intoTheCherno:masterfrom
Conversation
|
Hey Zod, this still has the problem of no updates happening when you just hold the border of the window with the mouse left button. This also causes huge delta times depending on how long you hold the border. I was able to get around this by updating and rendering in a separate thread, and synchronizing the window resizes using two std::atomic's (it has to be done in the main thread). The only thing that doesn't work with this approach is imgui's viewports (floating windows), which is fine for me given all the other benefits. https://github.com/MirrasHue/MirrasENGINE/blob/main/MirrasENGINE/src/Core/Application.cpp#L120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
fixes #632.
Proposed fix
This issue can be resolved by updating our Window and Layers during window resize event.