feat: add stdin support to providers, use stdin for OpenCodeProvider …#146
Open
letieu wants to merge 1 commit intoThePrimeagen:masterfrom
Open
feat: add stdin support to providers, use stdin for OpenCodeProvider …#146letieu wants to merge 1 commit intoThePrimeagen:masterfrom
letieu wants to merge 1 commit intoThePrimeagen:masterfrom
Conversation
…query Pass query via stdin instead of a CLI positional arg in OpenCodeProvider to avoid shell argument size limits. BaseProvider gains a _build_stdin hook (returns nil by default) that subclasses can override; make_request now forwards the result to vim.system's stdin option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass query via stdin instead of a CLI positional arg in OpenCodeProvider to avoid shell argument size limits.
BaseProvider gains a _build_stdin hook (returns nil by default) that subclasses can override; make_request now forwards the result to vim.system's stdin option.
This is error:
Note
Medium Risk
Touches request execution for all providers by wiring optional
stdinintovim.system, which could affect provider invocation if stdin/args expectations differ. Change is small and covered by updated unit tests forOpenCodeProvider.Overview
Adds a new optional
BaseProvider:_build_stdin()hook (defaultnil) and updatesBaseProvider:make_request()to pass the returned value intovim.systemasstdin.Updates
OpenCodeProviderto remove the query from its command args and instead provide it via_build_stdin, with accompanying test updates to assert the new behavior.Written by Cursor Bugbot for commit a5687d3. This will update automatically on new commits. Configure here.