Skip to content

fix: qflist filepath on windows#152

Open
corybsa wants to merge 2 commits intoThePrimeagen:masterfrom
corybsa:fix-windows-qf-path
Open

fix: qflist filepath on windows#152
corybsa wants to merge 2 commits intoThePrimeagen:masterfrom
corybsa:fix-windows-qf-path

Conversation

@corybsa
Copy link

@corybsa corybsa commented Mar 10, 2026

The parse_line function in lua/99/ops/qfix-helpers.lua splits path/line/column by matching the first : separators. On Windows paths like C:\repo\file.lua:10:3,1,note, this causes filename to become only C (drive letter), which breaks quickfix entries.

Edit: just wanted to add some visuals in case anybody was curious what it looks like in Windows:
Before this PR:
image

After this PR:
image


Note

Low Risk
Small, well-scoped parsing change with added test coverage; main risk is stricter numeric matching rejecting previously-accepted malformed inputs.

Overview
Fixes QFixHelpers.parse_line to only treat numeric lnum/col segments as the :/, separators, preventing Windows drive letters (e.g. C:\...) from being mis-parsed as the filename.

Adds a unit test covering Windows drive-letter paths to ensure quickfix entries are created with the full filepath and correct line/column values.

Written by Cursor Bugbot for commit 11f5152. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Free Tier Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant