Skip to content

Option to add extra args to providers#60

Merged
ThePrimeagen merged 2 commits intoThePrimeagen:masterfrom
klowdo:master
Mar 24, 2026
Merged

Option to add extra args to providers#60
ThePrimeagen merged 2 commits intoThePrimeagen:masterfrom
klowdo:master

Conversation

@klowdo
Copy link
Contributor

@klowdo klowdo commented Feb 2, 2026

option to add extra args to prompt.

In my case i don't want a session per code change in clause so i add "--no-session-persistence"

vim.iter is only available For Neovim 0.10+. don't know what version comp you looking for


Note

Medium Risk
Moderate risk because it changes how provider subprocess commands are constructed and allows arbitrary flags to be appended, which could break some provider CLIs depending on argument ordering.

Overview
Adds a new setup() option, provider_extra_args, which is stored on _99 state and validated as a list.

Updates BaseProvider:make_request to append these extra args to the generated provider command before spawning the subprocess, and adds tests covering state storage/defaulting for this option.

Written by Cursor Bugbot for commit f2b4281. This will update automatically on new commits. Configure here.

@ThePrimeagen
Copy link
Owner

master has changed a lot and i want to think about this still. I love the idea of passing additional params, but part of me thinks this should be on the opts passed into the function as opposed to on the state object.

i could go either way, but for now, let me think on it for a while.

also everything has been severely refactored. i am ~75% way through a great refactor and i will continue to refactor until my own morale improves :)

The big thing for me was making a more consistent and sensible interface to manage lifecycles of data.

now things are mostly good

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is kicking off a free cloud agent to fix this issue. This run is complimentary, but you can enable autofix for all future PRs in the Cursor dashboard.

Avoids breaking named options like GeminiCLI's --prompt flag.
@ThePrimeagen
Copy link
Owner

coming back to this almost a month later i still feel the same way, but i also get why this could be nice.

ill merge this in, though i dont know if this is a great / best solution

@ThePrimeagen
Copy link
Owner

the failing test is my fault

@ThePrimeagen ThePrimeagen merged commit e8185fe into ThePrimeagen:master Mar 24, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants