Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade API dependencies #6845

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Upgrade API dependencies #6845

merged 1 commit into from
Jan 19, 2024

Conversation

adriansmares
Copy link
Contributor

@adriansmares adriansmares commented Jan 19, 2024

Summary

This PR upgrades the dependencies used to generate our API (specifically pkg/ttnpb).

Changes

  • Upgrade protoc-gen-go to v1.32.0.
  • Upgrade protoc-gen-go-grpc to v1.60.1 (the generator is actually unchanged and still version v1.3.0).
  • Upgrade protoc-gen-grpc-gateway to v2.19.0.
    • This is the only change which actually changes the generated code - no behavioral changes are expected.
  • Upgrade sqlfmt to v0.21.0.
  • Bump the version of our own proto generators, but they are noop changes as we just published a new version in order to publish them to Buf.

Testing

Unit testing. No manual testing is required.

Regressions

If the dependencies have any behavioral changes, we could see transitive regressions. I've checked the changelog of the updated dependencies and did not see anything special.

Notes for Reviewers

No reviews required - CI only.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.29.0 milestone Jan 19, 2024
@adriansmares adriansmares self-assigned this Jan 19, 2024
@github-actions github-actions bot added the tooling Development tooling label Jan 19, 2024
@adriansmares adriansmares force-pushed the feature/upgrade-api-deps branch from 59bf18b to 4376555 Compare January 19, 2024 14:38
@adriansmares adriansmares marked this pull request as ready for review January 19, 2024 14:48
@adriansmares adriansmares requested a review from a team January 19, 2024 14:48
@adriansmares adriansmares requested a review from a team as a code owner January 19, 2024 14:48
@adriansmares adriansmares merged commit e641342 into v3.29 Jan 19, 2024
12 of 13 checks passed
@adriansmares adriansmares deleted the feature/upgrade-api-deps branch January 19, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Development tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant