Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console preferences migration #6857

Closed
wants to merge 1 commit into from

Conversation

nicholaspcr
Copy link
Contributor

Summary

References #6483

The deadline for the v3.29 is tomorrow and there is still ongoing work for API implementation, making it not viable for being merged and release on this exact version.

Doing just the migrations allows for the development and release of the console_preferences in the v3.29.1, since it won't break the API and the DB changes would still happen on this release.

Changes

  • Add necessary migration

Testing

Ran it locally and performed a few user operations.

Regressions

The default value for the new column in the users table is NULL and it should not impact any of the current operations.

Notes for Reviewers

I'm aware that in the enterprise the migration will be a bit different and I'll create a PR for that if this idea is deemed appropriate.

CC @adriansmares @KrishnaIyer

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@nicholaspcr nicholaspcr added the compat/db This could affect Database compatibility label Jan 23, 2024
@nicholaspcr nicholaspcr added this to the v3.29.0 milestone Jan 23, 2024
@nicholaspcr nicholaspcr self-assigned this Jan 23, 2024
@nicholaspcr nicholaspcr requested a review from a team as a code owner January 23, 2024 21:25
@github-actions github-actions bot added the c/identity server This is related to the Identity Server label Jan 23, 2024
@adriansmares
Copy link
Contributor

Per compatibility commitment, a v3.29.1 Console must work with an v3.29.0 Identity Server. Even if we migrate the Identity Server in time, the API gap would still be there.

I wouldn't rush this functionality, and instead would prefer that we consider doing this in the next minor. cc @KrishnaIyer for the next stack meeting.

@KrishnaIyer
Copy link
Member

ACK. Let's then target this for v3.30.0. We'll create a new target branch and an RFC for that.

@nicholaspcr nicholaspcr deleted the issue/6483-console-preferences-migration branch January 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/identity server This is related to the Identity Server compat/db This could affect Database compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants