Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user preferences store logic #6982

Merged
merged 6 commits into from
Mar 27, 2024

Conversation

ryaplots
Copy link
Contributor

Summary

This PR closes #6936

Changes

  • Add console preferences to request selectors
  • Add user preferences reducer
  • Add bookmarks store

Notes for Reviewers

Although the console_preferences are part of the user request payload, I added them in the userPreferences dedicated place in the store along with the bookmarks in order to keep all related information in the same place.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots requested a review from a team as a code owner March 11, 2024 12:42
@ryaplots ryaplots requested review from PavelJankoski and kschiffer and removed request for a team March 11, 2024 12:42
@github-actions github-actions bot added the ui/web This is related to a web interface label Mar 11, 2024
@kschiffer kschiffer added the c/console This is related to the Console label Mar 26, 2024
@ryaplots ryaplots merged commit 8c18654 into feature/console-redesign Mar 27, 2024
7 of 12 checks passed
@ryaplots ryaplots deleted the feature/user-preferences branch March 27, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants