Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impose support user rights limitation on GetAccessToken operation #7489

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Impose support user rights limitation on GetAccessToken operation #7489

merged 2 commits into from
Jan 28, 2025

Conversation

nicholaspcr
Copy link
Contributor

@nicholaspcr nicholaspcr commented Jan 28, 2025 •
edited
Loading

Summary

OS counterpart of https://github.com/TheThingsIndustries/lorawan-stack/pull/4517

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@nicholaspcr nicholaspcr self-assigned this Jan 28, 2025
@nicholaspcr nicholaspcr added this to the v3.33.1 milestone Jan 28, 2025
@github-actions github-actions bot added c/identity server This is related to the Identity Server compat/db This could affect Database compatibility labels Jan 28, 2025
@nicholaspcr nicholaspcr force-pushed the fix/client-support-user-rights-limitations branch from 3fdf7e3 to e02159e Compare January 28, 2025 11:20
@github-actions github-actions bot added c/gateway server This is related to the Gateway Server security This is important for security c/gateway conf server This is related to the Gateway Configuration Server ui/web This is related to a web interface compat/config This could affect Configuration compatibility labels Jan 28, 2025
@nicholaspcr nicholaspcr changed the base branch from v3.33 to v3.34 January 28, 2025 11:24
@nicholaspcr nicholaspcr force-pushed the fix/client-support-user-rights-limitations branch from e02159e to fa98cc6 Compare January 28, 2025 11:25
@nicholaspcr nicholaspcr marked this pull request as ready for review January 28, 2025 11:25
@nicholaspcr nicholaspcr requested a review from a team as a code owner January 28, 2025 11:25
@KrishnaIyer KrishnaIyer merged commit e2eb497 into v3.34 Jan 28, 2025
12 of 13 checks passed
@KrishnaIyer KrishnaIyer deleted the fix/client-support-user-rights-limitations branch January 28, 2025 12:17
nicholaspcr pushed a commit that referenced this pull request Jan 28, 2025
@KrishnaIyer @nicholaspcr
Merge pull request #7489 from TheThingsNetwork/fix/client-support-use…
cfb2518 
…r-rights-limitations

Impose support user rights limitation on GetAccessToken operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrishnaIyer KrishnaIyer KrishnaIyer approved these changes

Assignees

@nicholaspcr nicholaspcr

Labels
c/gateway conf server This is related to the Gateway Configuration Server c/gateway server This is related to the Gateway Server c/identity server This is related to the Identity Server compat/config This could affect Configuration compatibility compat/db This could affect Database compatibility security This is important for security ui/web This is related to a web interface
Projects
None yet
Milestone
v3.33.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholaspcr @KrishnaIyer