Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes related to the console redesign #7506

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Conversation

PavelJankoski
Copy link
Contributor

@PavelJankoski PavelJankoski commented Feb 11, 2025

Summary

  • "All" in the toggle element should be a link "View all →" on the top right of the panel (in end devices panel in an application overview)
  • Make the device image covering the container
  • Pulse animation broken on gateway status panel

Changes

  • Change toggle in end devices panel
  • Make device image as cover instead of contain
  • Change styles of status component

image

image

image

Testing

Steps
  1. Login to console.
  2. Select an application.
  3. Check end devices panel (first fix).
  4. Click on a device.
  5. Check if the device image is taking the full space of the container (second fix).
  6. Select connected gateway.
  7. Check the green pulse (third fix).
Results

The results should look like on the pictures I uploaded above.

Notes for Reviewers

There are some device pictures that need to be changed since they are unrecognizable after these changes. For example this one:
image

Looks like this:
image

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added the bug Something isn't working label Feb 11, 2025
@PavelJankoski PavelJankoski self-assigned this Feb 11, 2025
@PavelJankoski PavelJankoski requested a review from a team as a code owner February 11, 2025 14:51
@github-actions github-actions bot added the ui/web This is related to a web interface label Feb 11, 2025
@PavelJankoski PavelJankoski changed the title console: Change end devices panel and device picture Change end devices panel and device picture Feb 11, 2025
@PavelJankoski PavelJankoski changed the title Change end devices panel and device picture Fixes related to the console redesign Feb 11, 2025
@PavelJankoski PavelJankoski merged commit abb3dfc into v3.34 Feb 17, 2025
10 of 13 checks passed
@PavelJankoski PavelJankoski deleted the fix/console-redesign branch February 17, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants