Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values to static ADR in MAC settings #7512

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

PavelJankoski
Copy link
Contributor

Summary

Error: error:pkg/errors:validation (invalid `end_device`: embedded message failed validation); error:pkg/errors:validation (invalid `nb_trans`: value must be inside range [1, 15])
  at <anonymous> (./pkg/webui/lib/errors/utils.js:585:60)
  at ye.withScope (/libs.b2a0d7d5807e9467fde3.bundle.js:2:2547237)
  at Object.be [as withScope] (/libs.b2a0d7d5807e9467fde3.bundle.js:2:2547904)
  at Module.Ce (/libs.b2a0d7d5807e9467fde3.bundle.js:2:2548562)
  at ingestError (./pkg/webui/lib/errors/utils.js:577:5)
...
(6 additional frame(s) were not displayed)

Changes

  • Added default values for static ADR in MAC settings.

Testing

Steps

Go to device's general settings. Expand the Network layer, then expand Advanced MAC settings. Try selecting static( fields should already be populated with default values) and click save changes right away.

Results

There shouldn't be an error displayed.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added the bug Something isn't working label Feb 18, 2025
@PavelJankoski PavelJankoski self-assigned this Feb 18, 2025
@PavelJankoski PavelJankoski requested a review from a team as a code owner February 18, 2025 02:36
@github-actions github-actions bot added the ui/web This is related to a web interface label Feb 18, 2025
@PavelJankoski PavelJankoski merged commit 7ed1e23 into v3.34 Feb 19, 2025
12 of 13 checks passed
@PavelJankoski PavelJankoski deleted the fix/static-adr branch February 19, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants