Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentinel password to Redis failover configuration #7513

Closed
wants to merge 1 commit into from

Conversation

vlasebian
Copy link
Contributor

Summary

Add sentinel password to Redis failover configuration.

Changes

  • Add a new field, password, to the Redis failover config struct

Testing

  1. Start Redis in a Master-Replicas with Sentinel topology (e.g. with docker-compose)
  2. Update the stack config to contain the following Redis config:
cache:
  service: redis
  redis:
    password: <redis-password>
    failover:
      enable: true
      addresses: [ "localhost:26379" ]
      master-name: mymaster
      password: "<redis-sentinel-password>"

redis:
  password: <redis-password>
  failover:
    enable: true
    addresses: [ "localhost:26379" ]
    master-name: mymaster
    password: "<redis-sentinel-password>"

events:
  backend: redis
  redis:
    store:
      enable: true
    password: <redis-password>
    failover:
      enable: true
      addresses: [ "localhost:26379" ]
      master-name: mymaster
      password: "<redis-sentinel-password>"
  1. Start the stack and open the console.
  2. Create an application and an end device. If no redis errors are shown, then the connection was successful
Regressions

...

Notes for Reviewers

None.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@vlasebian vlasebian self-assigned this Feb 18, 2025
@github-actions github-actions bot added the compat/db This could affect Database compatibility label Feb 18, 2025
@vlasebian vlasebian closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat/db This could affect Database compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant