Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG #7516

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Update CHANGELOG #7516

merged 1 commit into from
Feb 19, 2025

Conversation

nicholaspcr
Copy link
Contributor

@nicholaspcr nicholaspcr commented Feb 19, 2025 •
edited
Loading

Summary

Merging the CHANGELOG entries of the v3.34.0 section into the unreleased section.

@nicholaspcr nicholaspcr added the blocking Another issue or pull request is waiting for this label Feb 19, 2025
@nicholaspcr nicholaspcr self-assigned this Feb 19, 2025
halimi
halimi reviewed Feb 19, 2025
View reviewed changes
@halimi
Copy link
Contributor

halimi commented Feb 19, 2025

It seems like there was a v3.34.0 section in the CHANGELOG which I initially thought it was early entries of v3.34 features but they were added at the beginning of December on the v3.33.0 release.

They were added to the v3.34.0 section because they are breaking changes that is why will be released in v3.34 even though developed during v3.33.0.

@nicholaspcr
Copy link
Contributor Author

It seems like there was a v3.34.0 section in the CHANGELOG which I initially thought it was early entries of v3.34 features but they were added at the beginning of December on the v3.33.0 release.

They were added to the v3.34.0 section because they are breaking changes that is why will be released in v3.34 even though developed during v3.33.0.

Thanks for the explanation.
I took the page limit default change as a non breaking change and assumed it was a mistake, my bad.

Will update the PR to have these entries into the unreleased section then

@nicholaspcr nicholaspcr changed the title Fix CHANGELOG Update CHANGELOG Feb 19, 2025
@nicholaspcr nicholaspcr requested a review from halimi February 19, 2025 16:10
@nicholaspcr nicholaspcr added this to the v3.34.0 milestone Feb 19, 2025
halimi
halimi reviewed Feb 19, 2025
View reviewed changes
@nicholaspcr nicholaspcr merged commit c31be90 into v3.34 Feb 19, 2025
2 of 3 checks passed
@nicholaspcr nicholaspcr deleted the fix/changelog branch February 19, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halimi halimi halimi approved these changes

@KrishnaIyer KrishnaIyer Awaiting requested review from KrishnaIyer

Assignees

@nicholaspcr nicholaspcr

Labels
blocking Another issue or pull request is waiting for this
Projects
None yet
Milestone
v3.34.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholaspcr @halimi