gs: Fix rctx field name in LBS LNS upstream messages - #8004
Merged
Conversation
vlasebian
marked this pull request as ready for review
August 21, 2026 14:19
vlasebian
force-pushed
the
fix/up-info-field-name
branch
from
August 21, 2026 14:30
fc019df to
0f4cd42
Compare
The rctx field in the upinfo object of upstream messages was misspelled as rtcx, so the radio context reported by gateways was ignored and the antenna index in the uplink metadata was always 0. The parsed value is now reflected in the uplink metadata and echoed in class A downlinks.
vlasebian
force-pushed
the
fix/up-info-field-name
branch
from
August 21, 2026 14:32
0f4cd42 to
7821167
Compare
nicholaspcr
approved these changes
Aug 25, 2026
johanstokking
approved these changes
Aug 26, 2026
johanstokking
left a comment
Member
There was a problem hiding this comment.
This fix is fine, but I'm not sure if this makes downlink work to other antennas than the first:
lorawan-stack/pkg/gatewayserver/io/io.go
Lines 345 to 349 in 9def57c
Let's merge this as-is and let's continue the discussion in #48.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Gateway Server parsed the
rctxfield in theupinfoobject of upstream messages of the LoRa Basics Station LNS protocol using a misspelled JSON tag (rtcx). Since Basics Station gateways sendrctx(per the LNS protocol), the radio context they reported was silently ignored and the antenna index was always 0. This PR fixes the field name so the value is actually consumed.Changes
UpInfo.RCtxfromrtcxtorctx.Testing
Steps
Run the package tests:
Results
Regressions
Behaviour changes on multi-radio Basics Station gateways.
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.