Update Core to 2.18 #325
Update Core to 2.18 #325
Conversation
|
This pull request has been linked to Shortcut Story #29964: [CSharp] Support aggregate pushdown. |
`tiledb_channel_operator` does not have a free function so it does not need a safe handle.
teo-tsirpanis
force-pushed
the
update-2.18
branch
from
39437b4 to
4822e62
Compare
| /// <remarks> | ||
| /// This class abstracts the <c>tiledb_channel_operation_t</c> type of the TileDB C API. | ||
| /// </remarks> | ||
| public abstract class AggregateOperation |
There was a problem hiding this comment.
I named this AggregateOperation instead of ChannelOperation or QueryChannelOperation. I believe it conveys its meaning better, and the first alternative is confusing (what is a channel?), and the second alternative is long.
This is a managed class that does not directly contain a tiledb_channel_operation_t*. Instead it encapsulates the logic to create it, which gets done when actually passed to the C API.
| /// <remarks> | ||
| /// This class abstracts the <c>tiledb_channel_operator_t</c> type of the TileDB C API. | ||
| /// </remarks> | ||
| public abstract class AggregateOperator |
There was a problem hiding this comment.
Same as AggregateOperation.
shaunrd0
left a comment
shaunrd0
left a comment
There was a problem hiding this comment.
Left a few comments, mostly small fixes for docs or questions on error handling. Looks really great overall 👍
|
Feedback addressed, CI is green, I'm going to merge it… |
2 participants
SC-29964