Disable AVX2 on nightly builds. #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
commented
Dec 22, 2023
| @@ -20,7 +20,7 @@ jobs: | |||
| matrix: | |||
| os: [ubuntu-latest, macos-latest, windows-latest] | |||
| include: | |||
| - BOOTSTRAP: ../bootstrap --enable-s3 --enable-serialization --force-build-all-deps --enable-vcpkg | |||
There was a problem hiding this comment.
--force-build-all-deps has no effect with vcpkg enabled.
ihnorton
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because building the Core and running the C# tests happens on separate jobs, they might run on a different machine. If the building machine supports AVX2 and the testing machine does not, the latter will fail with an invalid opcode error.
This is my latest theory on why the macOS nightly builds often fail, especially since nightly builds on other TileDB projects also fail on macOS. With this PR we always disable AVX2 when building the Core.
If this PR gets merged and we don't get a related nightly failure for two weeks, I will consider the failures fixed and will close all relevant issues.