Skip to content

Add pytest flaky-retry mechanism for handling intermittent test failures #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

kounelisagis
Copy link
Member

This PR introduces the @pytest.mark.flaky decorator to retry test_dask_multiattr_2d up to 3 times with a 2-second delay between attempts. This helps mitigate intermittent test failures caused by factors such as network instability, timeouts, or race conditions.

Fixes #2149

@kounelisagis kounelisagis requested a review from ihnorton February 4, 2025 12:30
@kounelisagis kounelisagis force-pushed the agis/fix-test-dask-communication-failure branch from a210073 to a1b9be5 Compare February 4, 2025 13:29
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM. Thanks

@johnkerl johnkerl changed the title Add pytest flaky retry mechanism for handling intermittent test failures Add pytest flaky-retry mechanism for handling intermittent test failures Feb 13, 2025
@kounelisagis kounelisagis force-pushed the agis/fix-test-dask-communication-failure branch from 6bce7d4 to a99a4c7 Compare February 13, 2025 16:03
@kounelisagis kounelisagis merged commit eeb04e7 into main Feb 13, 2025
43 checks passed
@kounelisagis kounelisagis deleted the agis/fix-test-dask-communication-failure branch February 13, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The nightly build with earliest supported numpy job failed on Saturday (2025-02-01)
2 participants