Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip faketime tests on macOS #2154

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Skip faketime tests on macOS #2154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ jobs:
os:
- ubuntu-latest
- macos-13
# libfaketime tests fail on macos arm. Disable tests for now.
# - macos-14
- macos-14
- windows-latest
python-version: [ "3.9", "3.10", "3.11", "3.12", "3.13" ]
fail-fast: false
Expand Down Expand Up @@ -66,8 +65,8 @@ jobs:
run: brew install pkg-config
if: startsWith(matrix.os, 'macos')

- name: "Install libfaketime (linux and macOS)"
if: ${{ ! startsWith(matrix.os, 'windows') }}
- name: "Install libfaketime (Linux only)"
if: ${{ startsWith(matrix.os, 'ubuntu') }}
run: |
git clone https://github.com/wolfcw/libfaketime/
cd libfaketime
Expand Down
4 changes: 2 additions & 2 deletions tiledb/tests/test_timestamp_overrides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ def has_libfaketime():


@pytest.mark.skipif(
sys.platform == "win32" or not has_libfaketime(),
reason=f"libfaketime not installed. {'Not supported on Windows.' if sys.platform == 'win32' else ''}",
sys.platform != "linux2" or not has_libfaketime(),
reason=f"This test is only supported on Linux with libfaketime installed.",
)
class TestTimestampOverrides(DiskTestCase):
def test_timestamp_overrides(self):
Expand Down
Loading