-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Consider index passed, even if the current domain is present #2178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see a user-level repro script demonstrating the problem at the UX level, but, I suppose your unit-test case suffices for me to be able to reconstruct one.
I would also like to see some provenance of how/where this error was reported. Maybe just a Shortcut hyperlink in the Description section.
A user-level repro script is available on the Shortcut mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kounelisagis !
tiledb/array.py
Outdated
if ( | ||
start is None | ||
and stop is None | ||
and hasattr(array.schema, "current_domain") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When is this line false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true when no explicit index is requested (i.e., A[:]
) and the array has a non-empty current domain. In all other cases, this is false.
This PR fixes an issue originating from #2156, which resulted in the current domain being used whenever it was present. This caused problems when indexing with an explicit
idx
while a current domain was present, leading toidx
and nonempty domain not being used.cc. @ypatia
[sc-64437]