Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Consider index passed, even if the current domain is present #2178

Merged
merged 5 commits into from
Mar 26, 2025

Conversation

kounelisagis
Copy link
Member

@kounelisagis kounelisagis commented Mar 19, 2025

This PR fixes an issue originating from #2156, which resulted in the current domain being used whenever it was present. This caused problems when indexing with an explicit idx while a current domain was present, leading to idx and nonempty domain not being used.

cc. @ypatia


[sc-64437]

Copy link
Contributor

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see a user-level repro script demonstrating the problem at the UX level, but, I suppose your unit-test case suffices for me to be able to reconstruct one.

I would also like to see some provenance of how/where this error was reported. Maybe just a Shortcut hyperlink in the Description section.

@kounelisagis
Copy link
Member Author

I would like to see a user-level repro script demonstrating the problem at the UX level, but, I suppose your unit-test case suffices for me to be able to reconstruct one.

I would also like to see some provenance of how/where this error was reported. Maybe just a Shortcut hyperlink in the Description section.

A user-level repro script is available on the Shortcut mentioned.

@johnkerl johnkerl self-requested a review March 19, 2025 14:14
Copy link
Contributor

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kounelisagis !

tiledb/array.py Outdated
if (
start is None
and stop is None
and hasattr(array.schema, "current_domain")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is this line false?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true when no explicit index is requested (i.e., A[:]) and the array has a non-empty current domain. In all other cases, this is false.

@kounelisagis kounelisagis changed the title Change prioritization when considering the current domain Fix: Consider index passed, even if the current domain is present Mar 26, 2025
@kounelisagis kounelisagis merged commit 30b478d into main Mar 26, 2025
43 checks passed
@kounelisagis kounelisagis deleted the agis/current-domain-prioritization branch March 26, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants