Run tests of test_fork_ctx as subprocesses#2181
Merged
kounelisagis merged 1 commit intomainfrom Apr 2, 2025
Merged
Conversation
sgillies
approved these changes
Apr 2, 2025
Contributor
sgillies
left a comment
sgillies
left a comment
There was a problem hiding this comment.
@kounelisagis I don't understand why crashes were happening in the builds and not locally or in our CI tests, but this seems like a pragmatic solution.
ihnorton
reviewed
Apr 2, 2025
| _ = tiledb.Ctx() | ||
| mp = multiprocessing.get_context("fork") | ||
| p = mp.Process() | ||
| with pytest.warns(UserWarning, match="TileDB is a multithreading library"): |
Member
There was a problem hiding this comment.
We want to assert that this warning is raised...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the tests in
test_fork_ctx.pyto run as subprocesses, fixing #2175. This has been verified by running the "Build and test wheels" workflow against the current branch: run. The failure rate was previously 100% for macos.[sc-64149][sc-57975]