Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PYBIND11_MAKE_OPAQUE to type_erased_module.cc #482

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jparismorgan
Copy link
Contributor

@jparismorgan jparismorgan commented Aug 6, 2024

What

Here we add PYBIND11_MAKE_OPAQUE to type_erased_module.cc, as the docs say if your binding code consists of multiple compilation units, it must be present in every file.

We also add some more common types which were missing.

I tested performance, but it seems the same, which makes sense because we don't use std::vector to pass anything in type_erased_module.cc. But it's still seems good to set up this pattern while I was investigating what PYBIND11_MAKE_OPAQUE does.

Testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant