Add PYBIND11_MAKE_OPAQUE
to type_erased_module.cc
#482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Here we add
PYBIND11_MAKE_OPAQUE
totype_erased_module.cc
, as the docs sayif your binding code consists of multiple compilation units, it must be present in every file
.We also add some more common types which were missing.
I tested performance, but it seems the same, which makes sense because we don't use
std::vector
to pass anything intype_erased_module.cc
. But it's still seems good to set up this pattern while I was investigating whatPYBIND11_MAKE_OPAQUE
does.Testing
type_erased_module.cc
, the CI failed with a new error: https://github.com/TileDB-Inc/TileDB-Vector-Search/actions/runs/10269341077/job/28414557952?pr=482