Draft: Include r-tools build in release artifacts #5415
+24
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 30, 2024 11:12
added 8 commits
January 2, 2025 14:15
ihnorton
approved these changes
Feb 1, 2025
Comment on lines
+59
to
+62
| # - platform: linux-aarch64 | ||
| # os: linux-arm64-ubuntu24 | ||
| # triplet: arm64-linux-release | ||
| # manylinux: quay.io/pypa/manylinux_2_28_aarch64 |
There was a problem hiding this comment.
Suggested change
| # - platform: linux-aarch64 | |
| # os: linux-arm64-ubuntu24 | |
| # triplet: arm64-linux-release | |
| # manylinux: quay.io/pypa/manylinux_2_28_aarch64 | |
| - platform: linux-aarch64 | |
| os: linux-arm64-ubuntu24 | |
| triplet: arm64-linux-release | |
| manylinux: quay.io/pypa/manylinux_2_28_aarch64 |
| @@ -156,17 +159,21 @@ jobs: | |||
|
|
|||
| Publish-Release: | |||
| needs: | |||
| - Test-Release-Artifacts | |||
| # - Test-Release-Artifacts | |||
There was a problem hiding this comment.
Suggested change
| # - Test-Release-Artifacts | |
| - Test-Release-Artifacts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds rtools binaries into release artifacts. In order to upload/download artifacts and merge them into a single folder we had to upgrade upload/download-artifact to version 4.
Cannot merge until CI is fixed: #5412
TYPE: NO_HISTORY
DESC: RTools release binaries