Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-2.27] Do not set CC/CXX/cmake variables (#5434) #5439

Open
wants to merge 2 commits into
base: release-2.27
Choose a base branch
from
+1 −18
Open

[Backport release-2.27] Do not set CC/CXX/cmake variables (#5434) #5439

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df58d6b
Do not set CC/CXX/cmake variables
Jan 28, 2025
309cf64
Merge branch 'release-2.27' into backport/pr-5434-to-release-2.27
ihnorton Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions bootstrap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,26 +196,9 @@ if [ "${linkage}" = "shared" ] && [ "${enable_static_tiledb}" = "ON" ]; then
die "cannot specify both --linkage=shared and --enable-static-tiledb"
fi

# Check clang compiler
if [[ x"${CC}" = x"" ]]; then
CC=gcc
fi

if [[ x"${CXX}" = x"" ]]; then
CXX=g++
fi

cmake=`which cmake`

if [[ ! -x ${cmake} ]]; then
die "cannot find cmake"
fi

# Configure
${cmake} -DCMAKE_BUILD_TYPE=${build_type} \
cmake -DCMAKE_BUILD_TYPE=${build_type} \
-DCMAKE_INSTALL_PREFIX="${prefix_dirs}" \
-DCMAKE_C_COMPILER="${CC}" \
-DCMAKE_CXX_COMPILER="${CXX}" \
-DCMAKE_PREFIX_PATH="${dependency_dir}" \
-DBUILD_SHARED_LIBS=${build_shared_libs} \
-DTILEDB_ASSERTIONS=${tiledb_assertions} \
Expand Down
Loading