Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moya 및 Combine을 사용한 Network 리펙토링 #163
base: master
Are you sure you want to change the base?
Moya 및 Combine을 사용한 Network 리펙토링 #163
Changes from 42 commits
2675fd8
6072374
234bec5
0d80edf
f554462
8c90a07
1bdfc68
c6aa580
f80e638
3435112
51f480a
4dfe1af
516c02d
115b640
82539ac
dccb6d2
c8bb161
138d552
1a7e0db
60b8304
c367b9c
e83bd72
ec27002
a1531f5
b77f417
5437678
ebb5afa
9c517cb
89c5ef3
fd8ef4d
e550310
9238ebc
0a65a67
d4e899f
2c2ca7a
3091d08
9e8cd74
4d76aa8
c98a398
c0d0892
7a357a2
072325a
10b99ef
bc51802
aa72f11
b78ecae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(의견)
AuthAPI로 첫 path명과 동일하게 API 라우터 만들어 주신건 너무 좋은것 같습니다!
개인적인 추가 의견으로 API case와 path를 통일하면 좋겠다는 의견입니다,
API가 많아지다 보면 호출하는곳(사용하는곳)이 아닌 해당 파일의 path까지 와서 확인해야만 어떤 api인지 알 수 있어 이슈 디버깅하는 속도가 느려질것 같아요
회의때 의견 나누면 좋을것 같아서 코멘트 남깁니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
24.10.28 (iOS 회의 결과)