Merged
Conversation
themisvaltinos
force-pushed
the
toby/core
branch
2 times, most recently
from
b5bd762 to
08ba90c
Compare
izeigerman
reviewed
May 19, 2025
izeigerman
reviewed
May 19, 2025
izeigerman
reviewed
May 19, 2025
izeigerman
reviewed
May 19, 2025
izeigerman
reviewed
May 19, 2025
izeigerman
reviewed
May 19, 2025
izeigerman
reviewed
May 19, 2025
izeigerman
reviewed
May 19, 2025
izeigerman
reviewed
May 19, 2025
izeigerman
reviewed
May 21, 2025
izeigerman
reviewed
May 21, 2025
izeigerman
reviewed
May 21, 2025
izeigerman
reviewed
May 21, 2025
izeigerman
reviewed
May 21, 2025
Member
izeigerman
left a comment
izeigerman
left a comment
There was a problem hiding this comment.
This looks much cleaner, thank you!
VaggelisD
reviewed
May 22, 2025
Contributor
VaggelisD
left a comment
VaggelisD
left a comment
There was a problem hiding this comment.
Anything that touches mp code both scares and excites me :D Left a few comments to better understand the changes
themisvaltinos
force-pushed
the
toby/core
branch
2 times, most recently
from
a0965f5 to
35d7b04
Compare
Contributor
Author
|
thank you addressed the latest round of comments when you have a moment to have another look @izeigerman |
izeigerman
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds a
ProcessPoolExecutorfor parallel loading of a project's models. It also adds a mock executor for single-process scenarios, such as when the system doesn’t support fork. Also, it refactorsoptimized_query_cache_poolto use this unified execution logic, eliminating the need for separate sequential and parallel code paths.