Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

solved first half of day 3 #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

solved first half of day 3 #3

wants to merge 6 commits into from

Conversation

LovinLifee
Copy link
Contributor

No description provided.

@AzatothTheAwakened
Copy link
Member

Just some things that jumped in my eye:

Tile.java line 5: its better to declare multiple attributes in multiple lines rather than one

Day3.java line 55: The first 2 params seem to be always be 0, and the other 2 could be Replaced by a Tile object
Day3.java line 59: This method has a pretty high cognitive complexity. Maybe create some methods for each if body

@LovinLifee
Copy link
Contributor Author

refactored everything

@AzatothTheAwakened
Copy link
Member

please rename the methods according to contributing.md
Then its fine to merge.
Also did you branch now? since every other commit on your branch will be in the PR. I cannot merge it when you submit multiple ones

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LovinLifee @AzatothTheAwakened