Skip to content

Commit

Permalink
joss paper + doc minor updates
Browse files Browse the repository at this point in the history
  • Loading branch information
Tomaubier committed Feb 3, 2025
1 parent 240b112 commit 1fe57fa
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 44 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/python-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ jobs:
# run: brainglobe install -a example_mouse_100um

- name: Testing CoperniFUS
run: pytest tests/test_viewer.py
run: pytest tests/test_pqtg.py
28 changes: 28 additions & 0 deletions tests/_IGNORE_DEBUG_pqtg.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import weakref
import pyqtgraph as pg

pg.mkQApp()

def test_getViewWidget():
view = pg.PlotWidget()
vref = weakref.ref(view)
item = pg.InfiniteLine()
view.addItem(item)
assert item.getViewWidget() is view
del view
assert vref() is None
assert item.getViewWidget() is None

def test_getViewWidget_deleted():
view = pg.PlotWidget()
item = pg.InfiniteLine()
view.addItem(item)
assert item.getViewWidget() is view

# Arrange to have Qt automatically delete the view widget
obj = pg.QtWidgets.QWidget()
view.setParent(obj)
del obj

assert not pg.Qt.isQObjectAlive(view)
assert item.getViewWidget() is None
56 changes: 13 additions & 43 deletions tests/test_viewer.py
Original file line number Diff line number Diff line change
@@ -1,44 +1,14 @@
import weakref

import pyqtgraph as pg

pg.mkQApp()

def test_getViewWidget():
view = pg.PlotWidget()
vref = weakref.ref(view)
item = pg.InfiniteLine()
view.addItem(item)
assert item.getViewWidget() is view
del view
assert vref() is None
assert item.getViewWidget() is None

def test_getViewWidget_deleted():
view = pg.PlotWidget()
item = pg.InfiniteLine()
view.addItem(item)
assert item.getViewWidget() is view

# Arrange to have Qt automatically delete the view widget
obj = pg.QtWidgets.QWidget()
view.setParent(obj)
del obj

assert not pg.Qt.isQObjectAlive(view)
assert item.getViewWidget() is None

# import pytest
# from coperniFUS.viewer import Window, pyqtw

# @pytest.fixture
# def viewer_window(qtbot):
# """Fixture to create CoperniFUS viewer window."""
# window = Window(app=None, running_test=True)
# return window

# def test_brain_atlas(viewer_window):
# """Test tha the example atlas has been loaded."""
# assert viewer_window.windowTitle() == "CoperniFUS"
# # assert viewer_window.get_module_object_from_name('BrainAtlas').bg_atlas.atlas_name == 'example_mouse_100um'
import pytest
from coperniFUS.viewer import Window, pyqtw

@pytest.fixture
def viewer_window(qtbot):
"""Fixture to create CoperniFUS viewer window."""
window = Window(app=None, running_test=True)
return window

def test_brain_atlas(viewer_window):
"""Test tha the example atlas has been loaded."""
assert viewer_window.windowTitle() == "CoperniFUS"
# assert viewer_window.get_module_object_from_name('BrainAtlas').bg_atlas.atlas_name == 'example_mouse_100um'

0 comments on commit 1fe57fa

Please sign in to comment.