Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build Release configuration and fix compiler versions #212

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

gfardell
Copy link
Member

@gfardell gfardell commented Sep 13, 2024

Sets the correct compiler and toolkit to be used by the build.

Builds the shared library as 'RelWithDebInfo'. Previous build was defaulting to Debug as DCMAKE_BUILD_TYPE is not used by MSVC.

closes #211

@gfardell gfardell requested review from casperdcl and paskino and removed request for casperdcl September 13, 2024 13:07
Copy link
Member

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may have to use CRLF line endings since it's a batch file.

@gfardell
Copy link
Member Author

I think you may have to use CRLF line endings since it's a batch file.

odd... I edited and pushed from windows

@gfardell
Copy link
Member Author

gfardell commented Sep 13, 2024

PS C:\Users\[USER]\GitHub\CCPi-Regularisation-Toolkit\recipe> git ls-files --eol
i/crlf  w/crlf  attr/                   bld.bat
i/lf    w/crlf  attr/                   build.sh
i/lf    w/crlf  attr/                   conda_build_config.yaml
i/lf    w/crlf  attr/                   meta.yaml

@casperdcl
Copy link
Member

that's only after my latest commit :)

@gfardell gfardell requested a review from casperdcl September 13, 2024 15:15
@gfardell gfardell merged commit 2b99d0f into master Sep 13, 2024
12 checks passed
@gfardell gfardell deleted the windows_build branch September 13, 2024 15:38
gfardell added a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cuda PTX Error with RTX3090 on windows.
2 participants