-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update random number generator #2037
Open
hrobarts
wants to merge
13
commits into
master
Choose a base branch
from
update_random
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I looked at some different methods for random number generation
Pros: global seed
Use
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update AcquistionGeometry, ImageGeometry and VectorGeometry allocate method to use numpy PCG64DXSM random number generator. Avoids creating an array of float64 then casting to the array dtype, also works with seed.
This update will no longer allow users to set the random seed globally, which may have an impact where algorithms use allocate internally with no option to pass the seed. This is currently a problem with the PowerMethod - see #1585 for PR allowing seed to be passed.
Testing you performed
Tests in test_DataContainer and test_AcquisitionGeometry
Related issues/links
Closes #2033
Might close #804
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.