fix: replace window data

cypress/e2e/demo.cy.js

@@ -14,11 +14,13 @@ context("WM", () => {
   it("should maximize/restore window", () => {
     cy.contains("with title").click();
     cy.get("[data-testid='window-frame']").should("be.visible").as("window");
+    cy.get("@window").contains("scroll to bottom").should("be.enabled");
     cy.document().matchImage({ screenshotConfig });
     cy.get("@window").contains("with title").dblclick();
     cy.document().matchImage({ screenshotConfig });
     cy.get("button[name='zoom']").click();
     cy.document().matchImage({ screenshotConfig });
+    cy.get("@window").contains("close all").click();
   });
 
   it("should prevent window from going offscreen", () => {

src/demo/DebugButtons.tsx

@@ -18,6 +18,7 @@ export function DebugButtons({ currentId }: { currentId?: WindowId }): JSX.Eleme
       { title: "lazy loaded content", kind: DemoWindowKind.lazy },
       { title: "initial size", kind: DemoWindowKind.lazy, width: 700, height: 700 },
       { title: "minimal size (overflow fixed)", kind: DemoWindowKind.danger, width: 7000, height: 7000 },
+      { title: `fixed id`, id: "fixed", parent: null },
     ],
     [],
   );

src/store/action.ts

@@ -4,7 +4,7 @@ import { ThunkAction } from "./reducerWithThunk";
 
 export type Action =
   | { type: "CLEAR_WINDOWS" }
-  | { type: "OPEN_WINDOW"; windowData: WindowType<any, any> }
+  | { type: "OPEN_WINDOW"; windowData: WindowType }
   | { type: "CLOSE_WINDOW"; id: WindowId }
   | { type: "FOCUS_WINDOW"; id: WindowId };
 

src/store/actions.ts

@@ -33,11 +33,11 @@ export function openWindow<Kind extends number | string = any, Meta = never>({
 export function closeWindow(id: string = null): WMAction {
   return async (dispatch, getState) => {
     const state = getState();
+    dispatch({ type: "CLOSE_WINDOW", id });
     await Promise.all(
       getWindows(state)
-        .filter(({ parent }) => parent === id)
+        .filter((w) => w.parent === id && w.id !== id && w.id !== w.parent)
         .map(({ id }) => dispatch(closeWindow(id))),
     );
-    return await dispatch({ type: "CLOSE_WINDOW", id });
   };
 }

src/store/reducer.ts

@@ -8,11 +8,15 @@ export function withoutId<T extends { id: I }, I = string>(arr: T[], id: T["id"]
   return arr.filter((el) => id !== el.id);
 }
 
-const windows: Reducer<WindowType<any, any>[], Action> = (windows = [], action) => {
+const windows: Reducer<WindowType[], Action> = (windows = [], action) => {
   switch (action.type) {
     case "CLEAR_WINDOWS":
       return [];
     case "OPEN_WINDOW":
+      const existingWindow = windows.find((w) => w.id === action.windowData.id);
+      if (existingWindow) {
+        return windows.map((window) => (window === existingWindow ? action.windowData : window));
+      }
       return [...windows, action.windowData];
     case "CLOSE_WINDOW":
       return withoutId(windows, action.id);
@@ -26,13 +30,11 @@ const order: Reducer<WindowId[], Action> = (state = [], action) => {
     case "CLEAR_WINDOWS":
       return [];
     case "OPEN_WINDOW":
-      return uniq([action.windowData.id, ...state]);
+      return state.includes(action.windowData.id) ? state : uniq([action.windowData.id, ...state]);
     case "CLOSE_WINDOW":
       return without(state, action.id);
     case "FOCUS_WINDOW":
-      if (action.id !== state[0]) {
-        return uniq([action.id, ...state]);
-      }
+      return action.id !== state[0] ? uniq([action.id, ...state]) : state;
     default:
       return state;
   }