Ordering of map fields #7565
Open
Ordering of map fields #7565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vder
force-pushed
the
ordering_of_map_fields
branch
from
6659375 to
f6f8afa
Compare
arkadius
reviewed
Feb 14, 2025
| @@ -66,7 +67,7 @@ case class ToJsonEncoder( | |||
| case a: UUID => safeString(a.toString) | |||
| case a: DisplayJson => a.asJson | |||
| case a: scala.collection.Map[_, _] => encodeMap(a.toMap) | |||
| case a: java.util.Map[_, _] => encodeMap(a.asScala.toMap) | |||
| case a: java.util.Map[_, _] => encode(ListMap(a.asScala.toList: _*)) | |||
There was a problem hiding this comment.
It might by not optimal. You should check what is done in implementation. Maybe there is some better approach when we assume that given map is a LinkedHashMap? Can you write a micro benchmark for that and verify the difference in times between old serialization method vs the new one?
| .nodeResults("end") | ||
| .map(_.variableTyped[Map[_, _]]("mapVariable")) | ||
|
|
||
| result shouldBe List(Some(linkedHashMap)) |
There was a problem hiding this comment.
Does it check the order? I think that the intent would be more clear if you'd compare lists instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before merge