[NU-2048] Fix for invalid classloader used for resources in K8sDeploymentManager #7592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k.xml in K8sDeploymentManager
… for defaultMinimalIngress.conf wrong classloader
arkadius
changed the title
coutoPL
reviewed
Feb 25, 2025
...server/src/main/scala/pl/touk/nussknacker/ui/process/processingtype/ProcessingTypeData.scala
Outdated
Show resolved
Hide resolved
coutoPL
reviewed
Feb 25, 2025
|
|
||
| // We wrap created DeploymentManagerProvider with this handler to make sure that DM creation logic will use | ||
| // correct context classloader | ||
| class DeploymentManagerProviderCorrectClassloaderHandler( |
There was a problem hiding this comment.
we can add private [loader] to hint that it should not be used in other places.
| } | ||
| } | ||
|
|
||
| override def metaDataInitializer(config: Config): MetaDataInitializer = delegate.metaDataInitializer(config) |
There was a problem hiding this comment.
are we sure the other methods don't need the changed context class loader?
I'm not sure, but it seems we cannot exactly predict what the user (who implemented the deployment manager) can do, so wouldn't be safe to change the context class loaded in all these places?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before merge