Skip to content

Conversation

@TrangPham
Copy link
Owner

@TrangPham TrangPham commented Mar 28, 2025

Fixes

  • workflow steps

Proposed changes:

  • Updated documentation
  • Release process is automated and uses trusted publishers
  • Adds support for Django 5.2 and python 3.13
  • Drops support for Python 3.7

Tested via:

  • ran test release flow
  • manually smoke tested test pypi release

@TrangPham TrangPham changed the title fix steps/job names fix steps/job names in release workflows Apr 17, 2025
@TrangPham TrangPham marked this pull request as ready for review April 18, 2025 18:41
@TrangPham TrangPham requested a review from Copilot April 18, 2025 18:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes workflow step and job names in the release workflows while updating settings and documentation to support Django 5.2 and Python 3.13. Key changes include:

  • Conditional handling in settings modules to accommodate Django version differences.
  • Updates to setup.py classifiers and GitHub workflows to enable new Python and Django versions.
  • Minor style and documentation adjustments in tests and development process files.

Reviewed Changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_project/settings/local.py Added conditional STORAGES configuration for Django 4.2+ while preserving legacy settings.
tests/test_project/settings/base.py Introduced DJANGO_VERSION and conditional STORAGES setup along with updated static/media settings.
setup.py Included Django 4.2 and 5.2 and updated Python versions in classifiers.
docs/development_process.md Updated instructions with new commands and clarified release process steps.
docker-compose.dev.yml Removed platform specification for selenium configuration.
admin_confirm/tests/unit/test_confirm_change_and_add.py Streamlined test client post calls by removing extra lines.
admin_confirm/tests/integration/test_with_s3_storage.py Adjusted selenium calls and assertions for file changes and removals.
admin_confirm/tests/helpers.py Simplified test helper functions and updated selenium driver configuration.
README.md Updated badge formatting for the license display.
.github/workflows/test.yml Refined test matrix versions and updated localstack health endpoint.
.github/workflows/release.yml Renamed and restructured steps in the release workflow to support updated distributions.
.github/workflows/release-test.yml Modified test release workflow naming and minor steps for consistency.
Files not reviewed (2)
  • .env: Language not supported
  • Makefile: Language not supported

@TrangPham TrangPham merged commit a1c7b76 into main Apr 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants