-
Notifications
You must be signed in to change notification settings - Fork 18
fix steps/job names in release workflows #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes workflow step and job names in the release workflows while updating settings and documentation to support Django 5.2 and Python 3.13. Key changes include:
- Conditional handling in settings modules to accommodate Django version differences.
- Updates to setup.py classifiers and GitHub workflows to enable new Python and Django versions.
- Minor style and documentation adjustments in tests and development process files.
Reviewed Changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_project/settings/local.py | Added conditional STORAGES configuration for Django 4.2+ while preserving legacy settings. |
| tests/test_project/settings/base.py | Introduced DJANGO_VERSION and conditional STORAGES setup along with updated static/media settings. |
| setup.py | Included Django 4.2 and 5.2 and updated Python versions in classifiers. |
| docs/development_process.md | Updated instructions with new commands and clarified release process steps. |
| docker-compose.dev.yml | Removed platform specification for selenium configuration. |
| admin_confirm/tests/unit/test_confirm_change_and_add.py | Streamlined test client post calls by removing extra lines. |
| admin_confirm/tests/integration/test_with_s3_storage.py | Adjusted selenium calls and assertions for file changes and removals. |
| admin_confirm/tests/helpers.py | Simplified test helper functions and updated selenium driver configuration. |
| README.md | Updated badge formatting for the license display. |
| .github/workflows/test.yml | Refined test matrix versions and updated localstack health endpoint. |
| .github/workflows/release.yml | Renamed and restructured steps in the release workflow to support updated distributions. |
| .github/workflows/release-test.yml | Modified test release workflow naming and minor steps for consistency. |
Files not reviewed (2)
- .env: Language not supported
- Makefile: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed changes:
Tested via: