Password window remains after opening encrypted notes

[Joackk]

Description

After I enter the password and open the encrypted section, the encrypted window is still there and I need to F5 refresh to get her back to normal, here's the encrypted section that's been displayed

TriliumNext Version

0.91.3-beta

What operating system are you using?

Windows

What is your setup?

Local + server sync

Operating System Version

Windows10

Error logs

No response

[EventualDankDog]

Same issue in v0.91.5
I have the same setup as mentioned above, but instead of Windows 10 I use Windows 11

[Joackk]

Yes, I just tried the latest 0.91.5 and still have the same problem!

[pano9000]

I've reproduced it myself today as well.

[pano9000]

dev console shows the following errors, when browsing to a protected note:

[pano9000]

do we know, what the last version was, before the issue popped up?

if not, I'll try to pinpoint it later this week

[EventualDankDog]

do we know, what the last version was, before the issue popped up?

if not, I'll try to pinpoint it later this week

All I can say is, that in 0.90.12 this issue did not occur. Since I am not a Beta-user I do not know in which beta version this issue occured.

[pano9000]

@EventualDankDog thanks, that actually helps narrow it down already, because we now have a last known working state :-)

(I personally wasn't using protected notes until recently, when I was running the beta versions)

[pano9000]

so, this issue was introduced with e16f4a1

in that commit the TypeWidget class was changed to an abstract class and some methods as well (e.g. doRefresh), so they need to be implemented and are not "inherited" anymore (not a 100% OOP expert, but I think that is the gist of an abstract class).

in theory #1140 should be fix the issue, because it does implement "doRefresh"

[eliandoran]

Fixed in #1140.

@pano9000 , indeed it was a mistake on my side. I shouldn't refactor things around when we still haven't ported everything to TypeScript.

[pano9000]

@eliandoran no worries, I struggle with the same thing (mixing porting and refactoring), whenever I want to start porting stuff from JS to TS ;-)

but ideally of course one would need to split that into two separate steps (which is definitely sometimes hard :-D)