Skip to content

Fix the password box not removed after entering protected mode #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

dousha
Copy link
Contributor

@dousha dousha commented Feb 8, 2025

Implementing doRefresh(.) for ProtectedSessionTypeWidget fixes the issue mentioned in #1078.

Maybe a default implementation for doRefresh(.) in TypeWidget would be better?

@dousha dousha changed the title Fix the password box not removed after entering protected mode (#1078) Fix the password box not removed after entering protected mode Feb 8, 2025
@pano9000
Copy link
Member

Kindly check my comment here:
#1078 (comment)

your fix, would be correct, from what I can tell – as it implements the "doRefresh" method, which got turned into an abstract method in the commit e16f4a1

not sure what the reason was, but there will have been one I guess

@eliandoran what do you think?

@pano9000
Copy link
Member

also: the previous "default implementation" was indeed exactly what you did in your commit here, so it should be OK I think.

Previous "default implementation" in type_widget.js:

async doRefresh(note) {}

Copy link
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dousha , thank you for your help.

@eliandoran eliandoran merged commit 8b9b843 into TriliumNext:develop Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants