chore: fix clippy warnings #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good point. Thank you. I didn't know I could change those settings 😅 |
|
Interesting with the wasm errors 🤔 not sure what's up with thar. |
It's not related to this PR but I'll probably need to fix it before I cut a release. I think the CI just has a bug |
|
The wasm CI issue should be fixed in #218 |
|
Ah, nice 👍 |
|
could we land these to unblock #215? 😀 |
|
looks green 🎉 |
eopb
approved these changes
Feb 18, 2025
|
No worries, thanks for maintaining it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed these failing in #215. Seems better to address warnings from new version of
clippyseparately.I just ran
cargo clippy --all-targets --all-features --fix(it might be a good idea to turn on CI for all PRs, that way the feedback loop is a bit tighter 😅 mostly a coincidence I checked if the PR had gotten any feedback as there's no notification from GH when CI runs. but if CI ran when I opened the PR, I would have acted 2 days ago)